-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS-5912 - Updates to the argo cd CLI installation and reference sections #75177
RHDEVDOCS-5912 - Updates to the argo cd CLI installation and reference sections #75177
Conversation
🤖 Wed May 08 14:18:58 - Prow CI generated the docs preview: |
Hi, @anandf and @varshab1210: PTAL at the PR and help with your review inputs. Thanks! |
LGTM, thanks |
88e403a
to
5dbe692
Compare
@anandf I have fixed the review comments. PTAL at the revised PR and provide feedback. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ce56088
to
550db0a
Compare
Fixing SME review comments Fixing additional SME review comments Fixing peer review comments
550db0a
to
121a59c
Compare
Thanks @adellape for the review comments. I have addressed them all and squashed the commits too. PTAL at it and merge the PR if everything checks okay. |
@Srivaralakshmi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cherrypick gitops-docs-1.12 |
@Srivaralakshmi Should this be picked to |
@adellape: new pull request created: #75673 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@adellape Yes, CP to gitops-docs-1.13 too please! Thanks for asking :) |
/cherrypick gitops-docs-1.13 |
@adellape: #75177 failed to apply on top of branch "gitops-docs-1.13":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Srivaralakshmi As discussed on Slack, we're fine with the |
Jira issue: RHDEVDOCS-5912
Aligned team: DevTools
Cherry-pick to versions:
gitops-docs-1.12
Docs preview:
SME review: Completed by @anandf
QE review: Completed by @varshab1210
Peer review:
Additional information: This PR is related to #72634. The content was already reviewed and approved. Due to the content gateway link issue from the Engineering side, certain installation procedures were commented out during the GitOps 1.12 GA. This PR comments-in back those procedures while adding admonition and updates to the content gateway links and their steps. TY!